Skip to content

Add 'isCA' field to Certificate spec#658

Merged
jetstack-bot merged 2 commits intocert-manager:masterfrom
munnerz:is-ca
Aug 14, 2018
Merged

Add 'isCA' field to Certificate spec#658
jetstack-bot merged 2 commits intocert-manager:masterfrom
munnerz:is-ca

Conversation

@munnerz
Copy link
Copy Markdown
Member

@munnerz munnerz commented Jun 15, 2018

What this PR does / why we need it:

Adds an 'isCA' field to the Certificate spec.

This is required for resource validation (see #657). Once we have resource validation merged, we can add all sorts of checks to make sure this is not set on ACME certs 😄

Release note:

Add isCA field to Certificates

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 15, 2018
@jetstack-bot jetstack-bot requested a review from wallrj June 15, 2018 16:03
@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 16, 2018
@munnerz
Copy link
Copy Markdown
Member Author

munnerz commented Jun 16, 2018

/retest

@munnerz
Copy link
Copy Markdown
Member Author

munnerz commented Jun 25, 2018

This change will require some more involved work for the Vault Issuer, as it requires submitting to the sign-intermediate endpoint afaict

cc @vdesjardins

@munnerz munnerz mentioned this pull request Jul 11, 2018
Merged
@munnerz
Copy link
Copy Markdown
Member Author

munnerz commented Jul 18, 2018

/milestone 0.5

@munnerz
Copy link
Copy Markdown
Member Author

munnerz commented Jul 18, 2018

/milestone v0.5

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2018
@munnerz
Copy link
Copy Markdown
Member Author

munnerz commented Jul 20, 2018

Blocked on #735

@munnerz munnerz added this to the v0.5 milestone Jul 28, 2018
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2018
@munnerz munnerz force-pushed the is-ca branch 3 times, most recently from 3bd954b to 8dad390 Compare August 13, 2018 18:29
James Munnelly added 2 commits August 14, 2018 10:32
Add 'isCA' field to Certificate spec
8d3d095 
Signed-off-by: James Munnelly <james.munnelly@jetstack.io>
Regenerate reference docs
5ea2c68 
Signed-off-by: James Munnelly <james.munnelly@jetstack.io>
kragniz
kragniz approved these changes Aug 14, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@kragniz kragniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2018
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Aug 14, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kragniz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2018
@retest-bot
Copy link
Copy Markdown

retest-bot commented Aug 14, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot jetstack-bot merged commit dba15aa into cert-manager:master Aug 14, 2018
@munnerz munnerz deleted the is-ca branch January 29, 2019 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wallrj wallrj Awaiting requested review from wallrj

1 more reviewer

@kragniz kragniz kragniz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kragniz kragniz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v0.5

Development

Successfully merging this pull request may close these issues.

4 participants

@munnerz @jetstack-bot @retest-bot @kragniz