fix: structure of nameconstraint in CSR#6542
Merged
jetstack-bot merged 6 commits intocert-manager:masterfrom Dec 12, 2023
Merged
fix: structure of nameconstraint in CSR#6542jetstack-bot merged 6 commits intocert-manager:masterfrom
jetstack-bot merged 6 commits intocert-manager:masterfrom
Conversation
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
inteon
reviewed
Dec 11, 2023
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
Member
Author
|
/retest |
inteon
reviewed
Dec 12, 2023
inteon
reviewed
Dec 12, 2023
inteon
reviewed
Dec 12, 2023
inteon
reviewed
Dec 12, 2023
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Member
|
/retest |
Member
|
@tanujd11 I applied some additional cleanup changes, PTAL |
Member
Author
|
@inteon LGTM |
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Member
|
Thanks for fixing this issue @tanujd11 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jan 3, 2024
martin31821
reviewed
Mar 4, 2024
| return nil, err | ||
| } | ||
| nameConstraints.PermittedEmailAddresses = crt.Spec.NameConstraints.Permitted.EmailAddresses | ||
| nameConstraints.ExcludedURIDomains = crt.Spec.NameConstraints.Permitted.URIDomains |
Member
There was a problem hiding this comment.
Indeed, good catch!
If this bug is still present on master, could you maybe create a PR to fix this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Motivation
This PR is a follow up from #6500. According to #6500 (comment) by @inteon the CSR should follow a proper structure mentioned in the RFC, The self signed certificate was generating correctly but CSR structure was not compatible with the RFC. This PR fixes the issue by using the x509.go to marshal the nameConstraints from the API and https://github.com/golang/go/blob/46ea4ab5cb87e9e5d443029f5f1a4bba012804d3/src/crypto/x509/parser.go#L483 for parsing the nameConstraint extension into a certificate.
Kind
FixRelease Note