Skip to content

Replace deprecated pkcs12 function call with pkcs12.LegacyRC2#6517

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
inteon:use_pkcs12_legacyrc2
Nov 27, 2023
Merged

Replace deprecated pkcs12 function call with pkcs12.LegacyRC2#6517
jetstack-bot merged 1 commit intocert-manager:masterfrom
inteon:use_pkcs12_legacyrc2

Conversation

@inteon
Copy link
Copy Markdown
Member

@inteon inteon commented Nov 27, 2023 •
edited
Loading

This PR is a soft version of #6515.
It replaces the deprecated function calls with equivalent non-deprecated function calls.

Kind

/kind cleanup

Release Note

NONE

@jetstack-bot jetstack-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/testing Issues relating to testing size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 27, 2023
@inteon
Copy link
Copy Markdown
Member Author

inteon commented Nov 27, 2023

/retest

@SgtCoDFish
Copy link
Copy Markdown
Member

SgtCoDFish commented Nov 27, 2023

Looks to be a legit test failure:

pkg/controller/certificates/issuing/internal/keystore.go:62:16: undefined: pkcs12.LegacyRC2
pkg/controller/certificates/issuing/internal/keystore.go:72:16: undefined: pkcs12.LegacyRC2

@inteon
replace deprecated pkcs12 function call with pkcs12.LegacyRC2
6f7ebbe 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon inteon force-pushed the use_pkcs12_legacyrc2 branch from 46533e1 to 6f7ebbe Compare November 27, 2023 11:32
@inteon
Copy link
Copy Markdown
Member Author

inteon commented Nov 27, 2023

Looks to be a legit test failure:

pkg/controller/certificates/issuing/internal/keystore.go:62:16: undefined: pkcs12.LegacyRC2
pkg/controller/certificates/issuing/internal/keystore.go:72:16: undefined: pkcs12.LegacyRC2

Should be fixed now.

SgtCoDFish
SgtCoDFish approved these changes Nov 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Tests are passing, and I understand this to be a no-op. Thanks! 🚀

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2023
@jetstack-bot jetstack-bot merged commit 554ceac into cert-manager:master Nov 27, 2023
@SgtCoDFish SgtCoDFish mentioned this pull request Dec 1, 2023
Closed
@erikgb erikgb mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@inteon @SgtCoDFish @jetstack-bot