Add design/20230601.gateway-route-hostnames. by tommie · Pull Request #6124 · cert-manager/cert-manager

tommie · 2023-06-01T16:07:18Z

Pull Request Motivation

Discussed #6051 with @irbekrm, who suggested making a design doc.

Kind

design

Release Note

NONE

Signed-off-by: Tommie Gannert <tommie@gannert.se>

jetstack-bot · 2023-06-01T16:07:27Z

Hi @tommie. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

design/20230601.gateway-route-hostnames.md

Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: tommie <tommie@users.noreply.github.com>

jetstack-bot · 2023-11-13T20:53:03Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle stale

jetstack-bot · 2023-12-13T21:23:23Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle rotten
/remove-lifecycle stale

tommie · 2023-12-14T09:11:46Z

@jsoref is anything missing here?

jsoref

It seems fine to me (with these changes), but, I'd rather someone else approve...

design/20230601.gateway-route-hostnames.md

jetstack-bot · 2024-01-13T13:50:53Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to jetstack.
/close

jetstack-bot · 2024-01-13T13:50:56Z

@jetstack-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to jetstack.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

inteon · 2024-01-29T09:17:54Z

/remove-lifecycle rotten
/reopen

jetstack-bot · 2024-01-29T09:17:58Z

@inteon: Reopened this PR.

Details

In response to this:

/remove-lifecycle rotten
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

inteon

I like the design, I think it makes a lot of sense and will improve the experience for users of GatewayAPI. This has become even more important now that GatewayAPI v1 has been released.

/lgtm
/approve
/hold for other reviews/ @jsoref's changes to be added

jetstack-bot · 2024-02-06T14:53:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [inteon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tommie · 2024-02-06T16:06:07Z

@inteon Thank you. I'll get to the review comments shortly.

Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: tommie <tommie@users.noreply.github.com>

tommie · 2024-02-18T15:33:16Z

@inteon Suggestions applied.

inteon · 2024-02-18T19:13:00Z

Thank you very much!
This will be a great help to all contributors working on implementing this feature in the future ❤️.
/unhold
/lgtm

ljhlh49-dot · 2025-11-14T05:08:16Z

Pull Request Motivation

Discussed #6051 with @irbekrm, who suggested making a design doc.

Kind

design

Release Note
NONE

Add design/20230601.gateway-route-hostnames.

c5dafb1

Signed-off-by: Tommie Gannert <tommie@gannert.se>

jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 1, 2023

jsoref reviewed Aug 15, 2023

View reviewed changes

design/20230601.gateway-route-hostnames.md Outdated Show resolved Hide resolved

design/20230601.gateway-route-hostnames.md Outdated Show resolved Hide resolved

design/20230601.gateway-route-hostnames.md Outdated Show resolved Hide resolved

Apply suggestions from review

1025858

Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: tommie <tommie@users.noreply.github.com>

jetstack-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 13, 2023

jetstack-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 13, 2023

jsoref reviewed Dec 14, 2023

View reviewed changes

jetstack-bot closed this Jan 13, 2024

jetstack-bot reopened this Jan 29, 2024

jetstack-bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 29, 2024

inteon reviewed Feb 6, 2024

View reviewed changes

jetstack-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Feb 6, 2024

jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024

Apply suggestions from @jsoref

f515aa7

Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: tommie <tommie@users.noreply.github.com>

jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2024

jetstack-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 18, 2024

jetstack-bot merged commit 8ea586e into cert-manager:master Feb 18, 2024

maelvls mentioned this pull request Jul 3, 2025

Design: support Gateway API's new XListenerSet resource #7839

Merged

Conversation

tommie commented Jun 1, 2023

Pull Request Motivation

Kind

Release Note

Uh oh!

jetstack-bot commented Jun 1, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jetstack-bot commented Nov 13, 2023

Uh oh!

jetstack-bot commented Dec 13, 2023

Uh oh!

tommie commented Dec 14, 2023

Uh oh!

jsoref left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jetstack-bot commented Jan 13, 2024

Uh oh!

jetstack-bot commented Jan 13, 2024

Uh oh!

inteon commented Jan 29, 2024

Uh oh!

jetstack-bot commented Jan 29, 2024

Uh oh!

inteon left a comment

Choose a reason for hiding this comment

Uh oh!

jetstack-bot commented Feb 6, 2024

Uh oh!

tommie commented Feb 6, 2024

Uh oh!

tommie commented Feb 18, 2024

Uh oh!

inteon commented Feb 18, 2024

Uh oh!

ljhlh49-dot commented Nov 14, 2025

Pull Request Motivation

Kind

Release Note

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants