Skip to content

[release-1.10] Set the Vault namespace using vault SDK client methods instead of using raw request object#5600

Merged
jetstack-bot merged 6 commits intocert-manager:release-1.10from
jetstack-bot:cherry-pick-5591-to-release-1.10
Feb 20, 2023
Merged

[release-1.10] Set the Vault namespace using vault SDK client methods instead of using raw request object#5600
jetstack-bot merged 6 commits intocert-manager:release-1.10from
jetstack-bot:cherry-pick-5591-to-release-1.10

Conversation

@jetstack-bot
Copy link
Copy Markdown
Contributor

@jetstack-bot jetstack-bot commented Nov 23, 2022

This is an automated cherry-pick of #5591

/assign wallrj

Fixes a bug that caused the Vault issuer to omit the Vault namespace in requests to the Vault API.

@wallrj
Set the Vault namespace using the official method in the vault SDK
775ca3a 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj
Test
b8389e1 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj
Remove unused Sys methods
67460e2 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj
Remove unused Token method
a7d8c46 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj
Recreate the original behaviour of sending a Vault token to the unaut…
8aa7a48 
…henticated sys/health endpoint.

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj
Test that the Sign function *does* use the Vault namespace
494d9b5 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@jetstack-bot jetstack-bot mentioned this pull request Nov 23, 2022
Merged
@jetstack-bot
Copy link
Copy Markdown
Contributor Author

jetstack-bot commented Nov 23, 2022

@jetstack-bot: This PR is not for the master branch but does not have the cherry-pick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 23, 2022
@ldemailly
Copy link
Copy Markdown

ldemailly commented Dec 7, 2022

@inteon could this go through please / make its way into 1.10.2?
TIA

@inteon inteon requested a review from wallrj December 16, 2022 16:03
@inteon
Copy link
Copy Markdown
Member

inteon commented Dec 16, 2022

@wallrj is this ready to be merged?

@ldemailly
Copy link
Copy Markdown

ldemailly commented Jan 3, 2023

ping

@wallrj
Copy link
Copy Markdown
Member

wallrj commented Jan 31, 2023

Sorry for the delay.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2023
@inteon
Copy link
Copy Markdown
Member

inteon commented Jan 31, 2023

/approve
/lgtm

@jetstack-bot
Copy link
Copy Markdown
Contributor Author

jetstack-bot commented Jan 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, jetstack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2023
@jetstack-bot jetstack-bot merged commit 28ec1c5 into cert-manager:release-1.10 Feb 20, 2023
@ldemailly
Copy link
Copy Markdown

ldemailly commented Feb 20, 2023

no worries, thanks, we'd switched to 1.11 anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wallrj wallrj Awaiting requested review from wallrj

Assignees

@wallrj wallrj

@inteon inteon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. lgtm Indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jetstack-bot @ldemailly @inteon @wallrj