Add a build tag for the e2e test only#4755
Conversation
This was initially part of cert-manager#4565 which was closed in favour of moving integration tests, but the consensus was that the e2e test is a special case. The e2e test requires so much more ahead-of-time setup that our bazel build flow special cases it by marking it manual. This is a `go test` equivalent to that, which enables the e2e test to remain under the test/ directory while still allowing `go test ./test/...` to work generally for all other tests. We'll add make targets for the e2e tests down the road. For now, we add the build tag and define it in bazel so this commit should be a no-op in effect. Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
c62a50f to
f2d8a33
Compare
|
/test all |
|
/test |
|
@SgtCoDFish: The
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cert-manager-e2e-v1-18 |
|
@SgtCoDFish: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test pull-cert-manager-e2e-v1-18 |
|
I agree about e2e tests being a special case after the discussion we had 👍🏼 I've not tried running this branch locally, but looking at which tests where skipped for this PR and which tests where skipped for another PR, the numbers are the same, so no reason to doubt if the tag works. (This did make me randomly wonder whether we should name the tests somehow better as by looking at the skipped tests, it is not possible to tell why they are skipped, but that is completely unrelated to this PR) /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irbekrm, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was initially part of #4565 which was closed in favour of moving integration tests, but the consensus was that the e2e test is a special case.
The e2e test requires so much more ahead-of-time setup that our bazel build flow special cases it by marking it manual. This is a
go testequivalent to that, which enables the e2e test to remain under thetest/directory while still allowinggo test ./test/...to work generally for all other tests.We'll add make targets for the e2e tests down the road. For now, we add the build tag and define it in bazel so this commit should be a no-op in effect.
/kind cleanup