move RFC2136 DNS01 tests to test/integration#4730
move RFC2136 DNS01 tests to test/integration#4730jetstack-bot merged 1 commit intocert-manager:masterfrom
Conversation
Since this test requires setup before it can successfully run, we define it as an integration test and move it here so that on a fresh checkout a user can always run `go test ./pkg/...` and expect that it would succeed. Also: - tweaks some comments - adds methods for getting nameserver / tsig algorithm from DNSProvider Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
irbekrm
left a comment
There was a problem hiding this comment.
This makes sense, I've ran go test ./pkg/... from this branch and the only test failing was the versionchecker one.
Thanks for improving the comments!
I guess at some point we may want to update the contributing docs with more info about testing strategy (everything with dependencies in integration tests) and how to run the different tests, but that may make more sense once the bazel -> make migration is done
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irbekrm, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Great minds think alike 😁 It's on my roadmap to do this after the migration, yeah 👌 |
Since this test requires setup before it can successfully run, we define it as an integration test and move it here so that on a fresh checkout a user can always run
go test ./pkg/...and expect that it would succeed.Also:
/kind cleanup