Add install for ginkgo which is used for e2e tests#4714
Add install for ginkgo which is used for e2e tests#4714jetstack-bot merged 1 commit intocert-manager:masterfrom
Conversation
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
jakexks
left a comment
There was a problem hiding this comment.
/lgtm
As an aside, how are we keeping bazel and Make tool versions in sync? by hand at the moment?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakexks, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yeah pretty much by hand; I'm keeping an eye on it. I'm kinda hoping that the make stuff won't take too long and there won't be much that will need to be updated in both make + bazel. |
Hm, with ginkgo specifically, installing using a version number encoded into the Makefile is actually a net addition in the number of places we need to maintain version numbers. Ginkgo is currently made available to Bazel via the With this change, we now need to maintain both the go.mod file as well as this Makefile (and will continue to need to do so with or without Bazel). Is there instead a way we can install the ginkgo binary at the version defined in the go.mod file? |
Fair point 👍 I've raised #4717 to do exactly this |
This is currently done by a bazel rule, but we need a local install of gingko that's done via Make.
This is part of the migration to make.
/kind feature