Skip to content

Three small goimports fixes against current HEAD#4705

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:goimports
Jan 4, 2022
Merged

Three small goimports fixes against current HEAD#4705
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:goimports

Conversation

@SgtCoDFish
Copy link
Copy Markdown
Member

@SgtCoDFish SgtCoDFish commented Jan 4, 2022

/kind cleanup

NONE

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/acme Indicates a PR directly modifies the ACME Issuer code area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/testing Issues relating to testing approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 4, 2022
irbekrm
irbekrm reviewed Jan 4, 2022
View reviewed changes
munnerz
munnerz reviewed Jan 4, 2022
View reviewed changes
@jetstack-bot jetstack-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 4, 2022
jakexks
jakexks reviewed Jan 4, 2022
View reviewed changes
@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2022
@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2022
@SgtCoDFish
three small goimports fixes against current HEAD
727e29a 
rather than using the default suggested `v1` names for some imports, we
use more descriptive names

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2022
jakexks
jakexks approved these changes Jan 4, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jakexks jakexks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2022
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Jan 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakexks, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SgtCoDFish
Copy link
Copy Markdown
Member Author

SgtCoDFish commented Jan 4, 2022

/unhold

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2022
@jetstack-bot jetstack-bot merged commit 97c4b7b into cert-manager:master Jan 4, 2022
@jetstack-bot jetstack-bot added this to the v1.7 milestone Jan 4, 2022
@SgtCoDFish SgtCoDFish deleted the goimports branch January 4, 2022 17:40
@SgtCoDFish SgtCoDFish mentioned this pull request Jan 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@munnerz munnerz munnerz left review comments

@jakexks jakexks jakexks approved these changes

+1 more reviewer

@irbekrm irbekrm irbekrm left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jakexks jakexks

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.7

Development

Successfully merging this pull request may close these issues.

5 participants

@SgtCoDFish @jetstack-bot @munnerz @jakexks @irbekrm