Skip to content

Include HTTPS proxy variable in Helm values#3921

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
vshn:fix/helm-values
Apr 28, 2021
Merged

Include HTTPS proxy variable in Helm values#3921
jetstack-bot merged 1 commit intocert-manager:masterfrom
vshn:fix/helm-values

Conversation

@anothertobi
Copy link
Copy Markdown
Contributor

@anothertobi anothertobi commented Apr 26, 2021

What this PR does / why we need it:
The http_proxy key was defined twice and is therefore replaced once with the https_proxy key.

Release note:

NONE

@anothertobi
Include HTTPS proxy variable in Helm values
6d6d69a 
The `http_proxy` key was defined twice and is therefore replaced once with the `https_proxy` key.

Signed-off-by: Tobias Nehrlich <tobias.nehrlich@vshn.ch>
@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 26, 2021
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Apr 26, 2021

Hi @anothertobi. Thanks for your PR.

I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/deploy Indicates a PR modifies deployment configuration labels Apr 26, 2021
wallrj
wallrj approved these changes Apr 28, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anothertobi

/ok-to-test
/approve
/lgtm
/kind cleanup

@jetstack-bot jetstack-bot added ok-to-test kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Apr 28, 2021
@jetstack-bot jetstack-bot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 28, 2021
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Apr 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anothertobi, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2021
@jetstack-bot jetstack-bot merged commit bc5c5e1 into cert-manager:master Apr 28, 2021
@jetstack-bot jetstack-bot added this to the v1.4 milestone Apr 28, 2021
@maelvls maelvls mentioned this pull request Mar 6, 2022
Merged
@wallrj wallrj mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wallrj wallrj wallrj approved these changes

Assignees

@wallrj wallrj

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.4

Development

Successfully merging this pull request may close these issues.

3 participants

@anothertobi @jetstack-bot @wallrj