Skip to content

fix bump distroless/static#3741

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
teejaded:bump-distroless
Mar 24, 2021
Merged

fix bump distroless/static#3741
jetstack-bot merged 1 commit intocert-manager:masterfrom
teejaded:bump-distroless

Conversation

@teejaded
Copy link
Copy Markdown

@teejaded teejaded commented Mar 4, 2021 •
edited by jakexks
Loading

What this PR does / why we need it:

Update the distroless/static base image to fix DLA-2542-1, DLA-2509-1, DLA-2424-1

Which issue this PR fixes: fixes #3740

Special notes for your reviewer:

Release note:

Update distroless/static base image

@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Mar 4, 2021
@jetstack-bot jetstack-bot requested a review from jakexks March 4, 2021 20:38
@jetstack-bot jetstack-bot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 4, 2021
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Mar 4, 2021

Hi @teejaded. Thanks for your PR.

I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 4, 2021
@teejaded
fix bump distroless/static
7aed3d4 
Signed-off-by: TJ Miller <millert@us.ibm.com>
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Mar 4, 2021

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • e515e19 fix bump distroless/static
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jakexks
Copy link
Copy Markdown
Member

jakexks commented Mar 5, 2021

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 5, 2021
@jakexks
Copy link
Copy Markdown
Member

jakexks commented Mar 5, 2021

/kind cleanup

@jetstack-bot jetstack-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 5, 2021
@jakexks jakexks added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Mar 5, 2021
@jakexks
Copy link
Copy Markdown
Member

jakexks commented Mar 5, 2021

/override dco

@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Mar 5, 2021

@jakexks: jakexks unauthorized: /override is restricted to Repo administrators.

Details

In response to this:

/override dco

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakexks
Copy link
Copy Markdown
Member

jakexks commented Mar 5, 2021

/milestone v1.3

@jetstack-bot jetstack-bot added this to the v1.3 milestone Mar 5, 2021
@munnerz
Copy link
Copy Markdown
Member

munnerz commented Mar 24, 2021

/override dco

@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Mar 24, 2021

@munnerz: Overrode contexts on behalf of munnerz: dco

Details

In response to this:

/override dco

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@munnerz
Copy link
Copy Markdown
Member

munnerz commented Mar 24, 2021

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2021
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Mar 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz, teejaded

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2021
@jetstack-bot jetstack-bot merged commit 7204284 into cert-manager:master Mar 24, 2021
@SgtCoDFish SgtCoDFish mentioned this pull request May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakexks jakexks Awaiting requested review from jakexks

Assignees

@munnerz munnerz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.3

Development

Successfully merging this pull request may close these issues.

v1.2.0 images fail vulnerability scan

4 participants

@teejaded @jetstack-bot @jakexks @munnerz