Make Kubernetes API QPS throtteling configurable#3382
Merged
jetstack-bot merged 5 commits intocert-manager:masterfrom Oct 16, 2020
Merged
Make Kubernetes API QPS throtteling configurable#3382jetstack-bot merged 5 commits intocert-manager:masterfrom
jetstack-bot merged 5 commits intocert-manager:masterfrom
Conversation
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
munnerz
reviewed
Oct 14, 2020
munnerz
reviewed
Oct 14, 2020
munnerz
reviewed
Oct 14, 2020
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
Contributor
Author
|
/kind feature |
munnerz
reviewed
Oct 14, 2020
munnerz
reviewed
Oct 14, 2020
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
wallrj
requested changes
Oct 16, 2020
Member
wallrj
left a comment
There was a problem hiding this comment.
Looks good. Just one lingering typo.
| } | ||
|
|
||
| if o.KubernetesAPIBurst <= 0 { | ||
| return fmt.Errorf("invalid value for kube-api-burst: %v must be higher than 0", o.KubernetesAPIBurst) |
Member
There was a problem hiding this comment.
Is there a way to make it unlimited? 0 or -1 or something else?
Contributor
Author
There was a problem hiding this comment.
Not supported by client-go... 0 is equal to the default value
Signed-off-by: Maartje Eyskens <maartje@eyskens.me> Co-authored-by: Richard Wall <wallrj@users.noreply.github.com>
wallrj
approved these changes
Oct 16, 2020
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: meyskens, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With the new controllers independently checking and setting state we caused more requests to be made to the API.
In large deployments this will cause a lot of throttling errors. Setting it much higher for all users would not be a good idea.
So I decided to make it a config flag on the controller.
Release note: