Disable controller admission webhook in ingress nginx for e2e#3042
Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom Jun 29, 2020
Merged
Disable controller admission webhook in ingress nginx for e2e#3042jetstack-bot merged 1 commit intocert-manager:masterfrom
jetstack-bot merged 1 commit intocert-manager:masterfrom
Conversation
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
Contributor
Author
|
/test pull-cert-manager-e2e-v1-11 |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: meyskens, munnerz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
this sets
controller.admissionWebhooks.enabled=falsefor the Nginx ingress deployed for e2e tests as we do not use this.This being true failed older Kubernetes versions as their webhook configuration was not backwards compatible with Kubernetes 1.11 and 1.12.
Release note:
/kind cleanup