Skip to content

[release-0.12] webhook: don't use time.Tick to prevent leaks#2468

Merged
jetstack-bot merged 1 commit intocert-manager:release-0.12from
jetstack-bot:cherry-pick-2467-to-release-0.12
Dec 16, 2019
Merged

[release-0.12] webhook: don't use time.Tick to prevent leaks#2468
jetstack-bot merged 1 commit intocert-manager:release-0.12from
jetstack-bot:cherry-pick-2467-to-release-0.12

Conversation

@jetstack-bot
Copy link
Copy Markdown
Contributor

@jetstack-bot jetstack-bot commented Dec 16, 2019

This is an automated cherry-pick of #2467

/assign munnerz

Fix bug causing ever-increasing CPU usage in webhook component

@munnerz
Don't use time.Tick to prevent leaks
5b9acf6 
Signed-off-by: James Munnelly <james@munnelly.eu>
@jetstack-bot jetstack-bot mentioned this pull request Dec 16, 2019
Merged
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Dec 16, 2019
@jetstack-bot jetstack-bot added this to the v0.12 milestone Dec 16, 2019
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Dec 16, 2019
@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 16, 2019
@munnerz
Copy link
Copy Markdown
Member

munnerz commented Dec 16, 2019

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2019
@jetstack-bot
Copy link
Copy Markdown
Contributor Author

jetstack-bot commented Dec 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jetstack-bot, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2019
@munnerz munnerz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Dec 16, 2019
@jetstack-bot jetstack-bot merged commit 7f31746 into cert-manager:release-0.12 Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshVanL JoshVanL Awaiting requested review from JoshVanL

Assignees

@munnerz munnerz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v0.12

Development

Successfully merging this pull request may close these issues.

2 participants

@jetstack-bot @munnerz