Skip to content

CleanUp ACME challenges after issuing and on delete using finalizer#1116

Merged
jetstack-bot merged 3 commits into
cert-manager:masterfrom
munnerz:cleanup-challenges
Nov 29, 2018
Merged

CleanUp ACME challenges after issuing and on delete using finalizer#1116
jetstack-bot merged 3 commits into
cert-manager:masterfrom
munnerz:cleanup-challenges

Conversation

@munnerz

@munnerz munnerz commented Nov 28, 2018

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Previously, we only cleaned up challenge resources if they succeeded. Any challenges that are deleted whilst they are failing/pending, will not be cleaned up.

This PR adds a finalizer to the challenge resources, and cleans them up upon deletion if they have not already been cleaned up.

Release note:

Add Challenge resource finalizer to handle cleanup

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Nov 28, 2018
@jetstack-bot jetstack-bot requested a review from kragniz November 28, 2018 21:36
@jetstack-bot jetstack-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 28, 2018
@munnerz
CleanUp ACME challenges after issuing and on delete using finalizer
dd8f987 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Update acmechallenges unit tests
0656d6c 
Signed-off-by: James Munnelly <james@munnelly.eu>
@jetstack-bot jetstack-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2018
@munnerz munnerz added this to the v0.6 milestone Nov 28, 2018
@munnerz

munnerz commented Nov 28, 2018

Copy link
Copy Markdown
Member Author

/retest

@munnerz
Ensure finalizer is always removed after one sync
93a7a89 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz

munnerz commented Nov 29, 2018

Copy link
Copy Markdown
Member Author

/retest

kragniz
kragniz approved these changes Nov 29, 2018
View reviewed changes

@kragniz kragniz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2018
@jetstack-bot

jetstack-bot commented Nov 29, 2018

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kragniz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2018
@retest-bot

retest-bot commented Nov 29, 2018

Copy link
Copy Markdown

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@munnerz

munnerz commented Nov 29, 2018

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@munnerz

munnerz commented Nov 29, 2018

Copy link
Copy Markdown
Member Author

/retest

@retest-bot

retest-bot commented Nov 29, 2018

Copy link
Copy Markdown

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@retest-bot

retest-bot commented Nov 29, 2018

Copy link
Copy Markdown

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot jetstack-bot merged commit f4e5203 into cert-manager:master Nov 29, 2018
@munnerz munnerz deleted the cleanup-challenges branch January 29, 2019 23:37
@jsoref jsoref mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kragniz kragniz kragniz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kragniz kragniz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v0.6

Development

Successfully merging this pull request may close these issues.

4 participants

@munnerz @jetstack-bot @retest-bot @kragniz