Skip to content

revisionHistoryLimit: should be omitted from the Deployment yaml unless the value is set #6712

@wallrj

Description

@wallrj

Discovered while releasing v1.14.1.

revisionHistoryLimit: should be omitted from the Deployment yaml unless the value is set.

E.g.

diff -u <(helm template cert-manager --repo https://v1-14-0.jetstack-charts.pages.dev/ --version v1.13.x | grep -v '[app.kubernetes.io/version](http://app.kubernetes.io/version)\|helm.sh/chart') <(helm template _bin/cert-manager-v1.14.1-1-g6e52ae13660281.tgz | grep -v '[app.kubernetes.io/version](http://app.kubernetes.io/version)\|helm.sh/chart')
@@ -975,6 +964,7 @@
     app.kubernetes.io/managed-by: Helm
 spec:
   replicas: 1
+  revisionHistoryLimit: 
   selector:
     matchLabels:
       app.kubernetes.io/name: webhook

Originally posted by @wallrj in #6248 (comment)

/kind bug

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions