-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Warn users not to use insecure TSIG algorithms when using DNS UPDATE and ACME DNS01 #6580
Copy link
Copy link
Closed
Labels
lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Description
- SHA1 and MD5 are allowed by our API but they are insecure.
- We could return a deprecation warning if those are used.
cert-manager/internal/apis/certmanager/validation/issuer.go
Lines 386 to 392 in 833311d
| // This list must be kept in sync with pkg/issuer/acme/dns/rfc2136/rfc2136.go | |
| var supportedTSIGAlgorithms = []string{ | |
| "HMACMD5", | |
| "HMACSHA1", | |
| "HMACSHA256", | |
| "HMACSHA512", | |
| } |
Links
- https://cert-manager.io/docs/configuration/acme/dns01/rfc2136/
- https://cert-manager.io/docs/reference/api-docs/#acme.cert-manager.io/v1.ACMEIssuerDNS01ProviderRFC2136
- Use our own implementation of miekg/dns.TsigProvider interface #4958
- RFC 2136: Dynamic Updates in the Domain Name System (DNS UPDATE)
Originally posted by @inteon in #6579 (comment)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.