-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Use go/x/crypto functionality for ACME External Account Binding #3822
Copy link
Copy link
Closed
Labels
area/acmeIndicates a PR directly modifies the ACME Issuer codeIndicates a PR directly modifies the ACME Issuer codekind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Description
We currently use a fork of golang/crypto library - see #3220 for context.
There are two bits of functionality that our fork implements on top of an older version of upstream- support for ACME External Account Binding and support for fetching alternative certificate chains.
As support for External Account Binding is now implemented upstream so we can:
- Fork the latest golang/crypto to
cert-managerorg - Cherry-pick the support for fetching alternative certificate chains on top of that
- Adapt
cert-managerto work with this fork - Document why we are using a fork
(There is an active CL upstream that implements supports fetching alternative certificate chains- once that gets merged, we'll be able to use upstream again).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/acmeIndicates a PR directly modifies the ACME Issuer codeIndicates a PR directly modifies the ACME Issuer codekind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.