Skip to content

Commit 515c37a

Browse files
jeremycampbell-oktajeremycampbell-okta
committed
rename new CRD attribute to IssuingCertificateURLs
Signed-off-by: Jeremy Campbell <jeremy.campbell@okta.com>
1 parent 6968ebd commit 515c37a

22 files changed

Lines changed: 56 additions & 61 deletions

‎deploy/crds/crd-clusterissuers.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1076,8 +1076,8 @@ spec:
10761076
required:
10771077
- secretName
10781078
properties:
1079-
caIssuers:
1080-
description: The CA Issuers list is an X.509 v3 extension that defines a list of URLs of CA Issuer Certificates. If not set, the certificate will be issued with no CA Issuers servers set. For example, a CA Issuers server URL could be "http://ca.domain.com/ca.crt".
1079+
issuingCertificateUrls:
1080+
description: issuingCertificateUrls is a list of URLs which this issuer should embed into certificates it creates. See https://www.rfc-editor.org/rfc/rfc5280#section-4.2.2.1 for more details. As an example, such a URL might be "http://ca.domain.com/ca.crt".
10811081
type: array
10821082
items:
10831083
type: string

‎deploy/crds/crd-issuers.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1076,8 +1076,8 @@ spec:
10761076
required:
10771077
- secretName
10781078
properties:
1079-
caIssuers:
1080-
description: The CA Issuers list is an X.509 v3 extension that defines a list of URLs of CA Issuer Certificates. If not set, the certificate will be issued with no CA Issuers servers set. For example, a CA Issuers server URL could be "http://ca.domain.com/ca.crt".
1079+
issuingCertificateUrls:
1080+
description: issuingCertificateUrls is a list of URLs which this issuer should embed into certificates it creates. See https://www.rfc-editor.org/rfc/rfc5280#section-4.2.2.1 for more details. As an example, such a URL might be "http://ca.domain.com/ca.crt".
10811081
type: array
10821082
items:
10831083
type: string

‎internal/apis/certmanager/types_issuer.go‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -293,12 +293,11 @@ type CAIssuer struct {
293293
// OCSP server URL could be "http://ocsp.int-x3.letsencrypt.org".
294294
OCSPServers []string
295295

296-
// The CA Issuers server list is an X.509 v3 extension that defines
297-
// a list of URLs of CA Issuers. If not set, the certificate will be
298-
// issued with no CA Issuers servers set. For example, a CA Issuers server
299-
// URL could be "http://ca.domain.com/ca.crt".
296+
// IssuingCertificateURLs is a list of URLs which this issuer should embed into certificates
297+
// it creates. See https://www.rfc-editor.org/rfc/rfc5280#section-4.2.2.1 for more details.
298+
// As an example, such a URL might be "http://ca.domain.com/ca.crt".
300299
// +optional
301-
CaIssuers []string `json:"caIssuers,omitempty"`
300+
IssuingCertificateURLs []string `json:"issuingCertificateUrls,omitempty"`
302301
}
303302

304303
// IssuerStatus contains status information about an Issuer

‎internal/apis/certmanager/v1/zz_generated.conversion.go‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎internal/apis/certmanager/v1alpha2/types_issuer.go‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -310,12 +310,11 @@ type CAIssuer struct {
310310
// +optional
311311
OCSPServers []string `json:"ocspServers,omitempty"`
312312

313-
// The CA Issuers server list is an X.509 v3 extension that defines
314-
// a list of URLs of CA Issuers. If not set, the certificate will be
315-
// issued with no CA Issuers servers set. For example, a CA Issuers server
316-
// URL could be "http://ca.domain.com/ca.crt".
313+
// IssuingCertificateURLs is a list of URLs which this issuer should embed into certificates
314+
// it creates. See https://www.rfc-editor.org/rfc/rfc5280#section-4.2.2.1 for more details.
315+
// As an example, such a URL might be "http://ca.domain.com/ca.crt".
317316
// +optional
318-
CaIssuers []string `json:"caIssuers,omitempty"`
317+
IssuingCertificateURLs []string `json:"issuingCertificateUrls,omitempty"`
319318
}
320319

321320
// IssuerStatus contains status information about an Issuer

‎internal/apis/certmanager/v1alpha2/zz_generated.conversion.go‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎internal/apis/certmanager/v1alpha2/zz_generated.deepcopy.go‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎internal/apis/certmanager/v1alpha3/types_issuer.go‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -310,12 +310,11 @@ type CAIssuer struct {
310310
// +optional
311311
OCSPServers []string `json:"ocspServers,omitempty"`
312312

313-
// The CA Issuers server list is an X.509 v3 extension that defines
314-
// a list of URLs of CA Issuers. If not set, the certificate will be
315-
// issued with no CA Issuers servers set. For example, a CA Issuers server
316-
// URL could be "http://ca.domain.com/ca.crt".
313+
// IssuingCertificateURLs is a list of URLs which this issuer should embed into certificates
314+
// it creates. See https://www.rfc-editor.org/rfc/rfc5280#section-4.2.2.1 for more details.
315+
// As an example, such a URL might be "http://ca.domain.com/ca.crt".
317316
// +optional
318-
CaIssuers []string `json:"caIssuers,omitempty"`
317+
IssuingCertificateURLs []string `json:"issuingCertificateUrls,omitempty"`
319318
}
320319

321320
// IssuerStatus contains status information about an Issuer

‎internal/apis/certmanager/v1alpha3/zz_generated.conversion.go‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎internal/apis/certmanager/v1alpha3/zz_generated.deepcopy.go‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)