teuthology/suite: use paddles solely for rerun info#1946
Merged
Conversation
teuthology.front no longer allows access to the run directories for general users. In fact, it's not required because we are already getting run information from paddles. This commit makes it more stringent in --rerun handling: if seed/subset/no_nested_subset do not match, exit failure rather than try to continue. Without a subset, many suites are so large that teuthology-suite will run for several minutes before ultimately failing to schedule due to the quantity of jobs. It also doesn't make sense to rerun a suite when these values do not match. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
yuriw
approved these changes
May 23, 2024
Contributor
yuriw
left a comment
There was a problem hiding this comment.
I tested this and was able to schedule https://pulpito.ceph.com/yuriw-2024-05-23_17:16:53-rados-wip-yuri5-testing-2024-05-15-0804-distro-default-smithi/
zmc
approved these changes
May 23, 2024
cbodley
reviewed
May 30, 2024
| log.info('Using rerun seed=%s', seed) | ||
| conf.seed = seed | ||
|
|
||
| subset = None if job0 is None else tuple(map(int, job0.get('subset').split('/'))) |
Contributor
There was a problem hiding this comment.
i see --rerun failing here with 'NoneType' object has no attribute 'split'. i generally run the rgw suite without --subset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
teuthology.front no longer allows access to the run directories for general users. In fact, it's not required because we are already getting run information from paddles.
This commit makes it more stringent in --rerun handling: if seed/subset/no_nested_subset do not match, exit failure rather than try to continue. Without a subset, many suites are so large that teuthology-suite will run for several minutes before ultimately failing to schedule due to the quantity of jobs. It also doesn't make sense to rerun a suite when these values do not match.