orchestra/run: add parameter shell to run()#1639
orchestra/run: add parameter shell to run()#1639rishabh-d-dave wants to merge 1 commit intoceph:masterfrom
Conversation
| # omit_sudo is used by vstart_runner.py | ||
| omit_sudo=False | ||
| omit_sudo=False, | ||
| shell=True |
There was a problem hiding this comment.
Needs docs below.
I wonder if it'd be better to do:
**kwargs
instead so we don't need to keep them in sync all the time?
There was a problem hiding this comment.
Needs docs below.
Added docs.
I wonder if it'd be better to do:
**kwargsinstead so we don't need to keep them in sync all the time?
I personally feel accepting arguments in the current fashion keeps the API easier to get a grip on and also keeps track of parameters that are acceptable.
There was a problem hiding this comment.
We should stop doing this, like adding useless parameters, and I was hopping we can get rid of omit_sudo as far as we added file operations api with sudo arguments. The vstart_runner.py should not hack teuthology, but it should use it in the correct way.
There was a problem hiding this comment.
As argument, the usin of shell=True is a feature already, otherwise multiline script commands will fail once trying to run in this mode.
Add parameter "shell" to teuthology.orchestra.run.run() with its default value set to "True" to allow compatiblity with vstart_runner.py and to also allow programs like vstart_runner.py to exercise greater flexibility. This should not affect code in teuthology since "shell" is set to "True" by default for every command executed. Fixes: https://tracker.ceph.com/issues/50178 Signed-off-by: Rishabh Dave <ridave@redhat.com>
6db38e9 to
4bef32f
Compare
|
Sorry guys, we must close this PR. |
|
@rishabh-d-dave is this PR still fixing the issue cited? I haven't seen that ticket reappear since April. |
|
Closing the PR since an alternative solution has been found - ceph/ceph#38481 (comment). |
Add parameter "shell" to teuthology.orchestra.run.run() with its default
value set to "True" to allow compatiblity with vstart_runner.py and to
also allow programs like vstart_runner.py to exercise greater
flexibility. This should not affect code in teuthology since "shell" is
set to "True" by default for every command executed.
Fixes: https://tracker.ceph.com/issues/50178