orchestra: refactor remote.py and remote_ops.py#1629
Closed
rishabh-d-dave wants to merge 2 commits intoceph:masterfrom
Closed
orchestra: refactor remote.py and remote_ops.py#1629rishabh-d-dave wants to merge 2 commits intoceph:masterfrom
rishabh-d-dave wants to merge 2 commits intoceph:masterfrom
Conversation
Contributor
Author
|
Depends on #1626. |
fbadec9 to
e58f0c5
Compare
Move methods that operate on a remote machine without depending on another remote machine from orchestra.remote.Remote to a different class in a different module. This enables applications like vstart_runner.py (in Ceph repo) to reuse these methods by a simple import for running tests locally without necessarily depending on SSH. Signed-off-by: Rishabh Dave <ridave@redhat.com>
Signed-off-by: Rishabh Dave <ridave@redhat.com>
e58f0c5 to
50d3a51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.