teuthology/misc: make the Valgrind's early exit configurable.#1600
Merged
jdurgin merged 1 commit intoceph:masterfrom Jan 19, 2021
Merged
teuthology/misc: make the Valgrind's early exit configurable.#1600jdurgin merged 1 commit intoceph:masterfrom
jdurgin merged 1 commit intoceph:masterfrom
Conversation
This commit is a follow-up to a98eb3e where Valgrind has been configured to exit on first-seen error as it was (wrongly!) assumed that all components are green when it comes to the Valgrind verification. This assumption turned out to be broken for RGW which got a few issues over the course as a result of having the Valgrind checks knocked out as a side effect of the python3 transition [1]. In the consequence, multiple problems accumulated and introducing a mechanism to disable the early exit to e.g. develop a list of these issues looks desirable. [1]: ceph#1503 (comment) Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 tasks
jdurgin
approved these changes
Jan 19, 2021
Member
jdurgin
left a comment
There was a problem hiding this comment.
seems like a reasonable option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is a follow-up to a98eb3e where Valgrind has been configured to exit on first-seen error as it was (wrongly!) assumed that all components are green when it comes to the Valgrind verification.
This assumption turned out to be broken for RGW which got a few issues over the course as a result of having the Valgrind checks knocked out as a side effect of the python3 transition [1]. In the consequence, multiple problems accumulated and introducing a mechanism to disable the early exit to e.g. develop a list of these issues looks desirable.
[1]: #1503 (comment)
Signed-off-by: Radoslaw Zarzynski rzarzyns@redhat.com