Skip to content

Setup development environment for teuthology on your laptop#1548

Merged
kshtsk merged 6 commits intoceph:masterfrom
kshtsk:wip-laptop
Sep 1, 2020
Merged

Setup development environment for teuthology on your laptop#1548
kshtsk merged 6 commits intoceph:masterfrom
kshtsk:wip-laptop

Conversation

@kshtsk
Copy link
Contributor

@kshtsk kshtsk commented Aug 13, 2020

No description provided.

@kshtsk kshtsk added the DNM label Aug 13, 2020
Kyr Shatskyy added 2 commits August 13, 2020 23:15
Add downburst environment variables to make it possible
to config disk number and disk size when locking machines
locally.

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
@kshtsk kshtsk force-pushed the wip-laptop branch 2 times, most recently from c4f82d3 to c8ed3be Compare August 14, 2020 08:43
@kshtsk kshtsk removed the DNM label Aug 24, 2020
@jdurgin
Copy link
Member

jdurgin commented Aug 25, 2020

very exciting! was just discussing similar ideas with @rzarzynski

jdurgin
jdurgin previously approved these changes Aug 27, 2020
Copy link
Member

@jdurgin jdurgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Looks like a nice way to setup a teuthology dev environment.

It'd be nice to get all these steps into a script of some sort, so it could be created with one command.
IIRC you mentioned downburst may need some changes to work with centos or fedora. Being able to use podman instead of docker would be nice too.

@kshtsk
Copy link
Contributor Author

kshtsk commented Aug 27, 2020

Great work! Looks like a nice way to setup a teuthology dev environment.

It'd be nice to get all these steps into a script of some sort, so it could be created with one command.

Yeah, this is what I am thinking about too. Shell script sounds fastest solution, but probably we can introduce a new tool, like teuthology-sandbox or similar.

IIRC you mentioned downburst may need some changes to work with centos or fedora.

Not sure I was saying about the downburst itself. But that make sense to, however I expect it be working.

Being able to use podman instead of docker would be nice too.

I was thinking about docker compose, but my colleges also want to podman, I will look into that.

@kshtsk kshtsk force-pushed the wip-laptop branch 4 times, most recently from aacabea to 3c19c00 Compare August 31, 2020 17:22
@kshtsk kshtsk changed the title [WIP] laptop Setting up development environment for teuthology on your laptop Aug 31, 2020
@kshtsk kshtsk changed the title Setting up development environment for teuthology on your laptop Setup development environment for teuthology on your laptop Aug 31, 2020
@kshtsk kshtsk force-pushed the wip-laptop branch 3 times, most recently from 96f1db7 to 91ec089 Compare August 31, 2020 18:05
@kshtsk kshtsk requested a review from jdurgin August 31, 2020 18:12
@kshtsk
Copy link
Contributor Author

kshtsk commented Aug 31, 2020

@jdurgin I've made some docs cleanup, could you please give another look.

@kshtsk kshtsk mentioned this pull request Aug 31, 2020
6 tasks
@kshtsk
Copy link
Contributor Author

kshtsk commented Aug 31, 2020

@susebot run deploy

@susebot
Copy link

susebot commented Aug 31, 2020

Commit 91ec089 is OK.
Check tests results in the Jenkins job: https://ceph-ci.suse.de/job/pr-teuthology-deploy/250/

jdurgin
jdurgin previously approved these changes Aug 31, 2020
Copy link
Member

@jdurgin jdurgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, well-documented and including troubleshooting steps is very helpful.

Kyr Shatskyy added 2 commits August 31, 2020 23:22
Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
Kyr Shatskyy added 2 commits August 31, 2020 23:22
Teuthology uses rsyslog, but opensuse-15.2 has conflicting
systemd-logger preinstalled.

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
@kshtsk
Copy link
Contributor Author

kshtsk commented Aug 31, 2020

@jdurgin I've addressed your comment, but the review is reset.

Copy link
Member

@jdurgin jdurgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems silly to reset the review for a typo :) maybe we can change the repo settings about that

@kshtsk kshtsk merged commit f1fe128 into ceph:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants