suite/run.py: check config['verify_ceph_hash'] before verifying ceph …#1520
Conversation
…packages there is chance that we don't have ceph packages built for the combination of specified os_type and os_version, for instance, in the case of rados/thash_old_clients, older ceph clients are installed on el7, but the ceph cluster is deployed using cephadm, which in turn pull ceph container images built using the ceph being tested and el8. since we've dropped the build of master on el7, there is no need to verify if ceph package is available if cephadm is used for deploying the cluster. Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
…abled Signed-off-by: Kefu Chai <kchai@redhat.com>
jdurgin
left a comment
There was a problem hiding this comment.
We should add a check for cephadm to see whether the containers it uses exist as well, in a future PR
i checked so, in short, let's revisit it after, probably 6 months. |
|
@tchaikov this PR is breaking install.repos mechanism |
| or (overrides and 'install' in overrides and 'repos' in overrides.get('install')) | ||
| if not ('redhat' in config or having_repos): | ||
| overrides = config.get('overrides', {}) | ||
| having_repos = ('repo' in config.get('install', {}) or |
There was a problem hiding this comment.
Here is unfortunate typo, this should be 'repos' instead of 'repo'.
|
Related fix #1521 |
…packages
there is chance that we don't have ceph packages built for the
combination of specified os_type and os_version, for instance, in the
case of rados/thash_old_clients, older ceph clients are installed on
el7, but the ceph cluster is deployed using cephadm, which in turn pull
ceph container images built using the ceph being tested and el8.
since we've dropped the build of master on el7, there is no need to
verify if ceph package is available if cephadm is used for deploying the
cluster.
Signed-off-by: Kefu Chai kchai@redhat.com