teuthology/orchestra/remote.py: write remote file without sudo#1465
Merged
tchaikov merged 1 commit intoceph:masterfrom May 7, 2020
Merged
teuthology/orchestra/remote.py: write remote file without sudo#1465tchaikov merged 1 commit intoceph:masterfrom
tchaikov merged 1 commit intoceph:masterfrom
Conversation
the remote file is created using "ubuntu" user. in ubuntu xenial, superuser is able to write to that file using tar, it seems that "tar" starts another process when writing to the dest file specified by "-f", and that process does not have the privilege for writing that file. so when we are trying to archive a directory on ubuntu/focal test node, we have following error: ``` tar (child): /tmp/tmp.vkl0kAtc06: Cannot open: Permission denied tar (child): Error is not recoverable: exiting now tar: /tmp/tmp.vkl0kAtc06: Cannot write: Broken pipe tar: Child returned status 2 tar: Error is not recoverable: exiting now ``` and this is reproduciable with tar 1.30: ``` $ touch /tmp/helloworld $ mkdir /tmp/foobar $ sudo tar czf /tmp/helloworld -C /tmp/foobar -- . tar (child): /tmp/helloworld: Cannot open: Permission denied tar (child): Error is not recoverable: exiting now tar: /tmp/helloworld: Cannot write: Broken pipe tar: Child returned status 2 tar: Error is not recoverable: exiting now ``` but we can workaround this by writing the temp file using "ubuntu" user, like ``` sudo tar czf - -C /tmp/foobar -- . > /tmp/helloworld ``` Signed-off-by: Kefu Chai <kchai@redhat.com>
Contributor
Author
|
this change should address the failures like |
Contributor
Author
|
i think these failures is a regression introduced by ceph/ceph#34894 |
jdurgin
approved these changes
May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the remote file is created using "ubuntu" user. in ubuntu xenial,
superuser is able to write to that file using tar, it seems that "tar"
starts another process when writing to the dest file specified by "-f",
and that process does not have the privilege for writing that file.
so when we are trying to archive a directory on ubuntu/focal test node,
we have following error:
and this is reproduciable with tar 1.30:
but we can workaround this by writing the temp file using "ubuntu" user, like
Signed-off-by: Kefu Chai kchai@redhat.com