rgw/logging: modify tests to allow for committing empty objects#688
Merged
yuvalif merged 1 commit intoceph:masterfrom Sep 9, 2025
Merged
rgw/logging: modify tests to allow for committing empty objects#688yuvalif merged 1 commit intoceph:masterfrom
yuvalif merged 1 commit intoceph:masterfrom
Conversation
14 tasks
nbalacha
reviewed
Sep 8, 2025
| src_names = [] | ||
| # make sure first flush is not happening in parllel | ||
| # TODO: this is caused by an unlikely race condtion | ||
| #_flush_logs(client, src_bucket_name) |
Contributor
There was a problem hiding this comment.
Did you mean to comment out this line?
Contributor
Author
There was a problem hiding this comment.
will delete the commented workaround.
code now handles the race condition on first flush :-)
so test should cover that
Comment on lines
+15840
to
+15841
| # make sure first flush is not happening in parllel | ||
| # TODO: this is caused by an unlikely race condtion |
Contributor
There was a problem hiding this comment.
Nit: typo
Suggested change
| # make sure first flush is not happening in parllel | |
| # TODO: this is caused by an unlikely race condtion | |
| # make sure first flush is not happening in parallel | |
| # TODO: this is caused by an unlikely race condition |
Contributor
|
Looks good otherwise. |
new tests were added and existing tests that assumed the previous behavior were modified. testing: ceph/ceph#65387 Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
f908d90 to
7283cd9
Compare
nbalacha
approved these changes
Sep 9, 2025
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new tests were added and existing tests that assumed the previous behavior were modified.
testing: ceph/ceph#65387