rgw/restore: Add rgw_restore_processor_period config option to determine restore time#686
Merged
soumyakoduri merged 1 commit intoceph:masterfrom Sep 23, 2025
Conversation
14 tasks
thotz
requested changes
Sep 8, 2025
| # check_request_timeout(client.get_object, Bucket=bucket, Key=key) | ||
| response = client.get_object(Bucket=bucket, Key=key) | ||
| time.sleep(2) | ||
| # time.sleep(2*restore_period) |
Contributor
There was a problem hiding this comment.
this being comment out from the testcase, please remove it
| # Iterate over the contents to find the StorageClass | ||
| if 'StorageClass' in response: | ||
| assert response['StorageClass'] == sc | ||
| else: # storage class should be STANDARD |
Contributor
There was a problem hiding this comment.
any specific reason why it is removed?
Contributor
Author
There was a problem hiding this comment.
It seemed like it wasn't necessary but I see this check was added on to check transition but to verify response has StorageClass if not for STANDARD.
7c5635c to
9e5cef8
Compare
Contributor
|
@thotz Please re-revies |
thotz
approved these changes
Sep 17, 2025
Contributor
thotz
left a comment
There was a problem hiding this comment.
If it passes teutology cases for cloud restore/transition. Then I am okay to merge this change
thotz
approved these changes
Sep 19, 2025
Contributor
|
Rebase all into one single commit? |
Contributor
Author
yes.. finally got the tests consistently passing |
This adjusts restore period as per ceph/ceph#64933 Also deleting lifecycle post transition so that temp restored files remain for a while without being re-transitioned immeditately. Signed-off-by: Soumya Koduri <skoduri@redhat.com>
b98887e to
deab93b
Compare
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With ceph/ceph#64933 , now the restore requests are processed asynchronously even for
cloud-s3tier types. This change includes optionrgw_restore_processor_periodto determine restore time before verifying in the tests.