s3: test conditional put_object() and delete_object()#673
Merged
AliMasarweh merged 9 commits intomasterfrom Jul 28, 2025
Merged
s3: test conditional put_object() and delete_object()#673AliMasarweh merged 9 commits intomasterfrom
AliMasarweh merged 9 commits intomasterfrom
Conversation
f74d07c to
7b7e4a5
Compare
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
7ed5d02 to
6ba7bd5
Compare
we expected an error if we delete non-existent objects but that is not true Signed-off-by: Ali Masarwa <ali.saed.masarwa@gmail.com>
93afdd1 to
b4e9ebf
Compare
Signed-off-by: Ali Masarwa <ali.saed.masarwa@gmail.com>
b4e9ebf to
8be24ac
Compare
Member
|
@cbodley : What's our policy for s3-tests PRs. Is a review with approval required? I looked at some other recently merged PRs and they all had a review with an approval. |
Contributor
no real policy. i often have to merge my own test prs without review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test coverage for ceph/ceph#63348
<ETag><LastModifiedTime><Size>put_object tests are duplicated to test non-versioned and overwrites of a current version
delete_object(s) tests are duplicated to test non-versioned, deletes of a current version, and deletes of a specific version