s3: test checksumming with streaming uploads#540
Open
cbodley wants to merge 1 commit intoceph:masterfrom
Open
Conversation
86e15d3 to
c619a9a
Compare
cbodley
commented
Feb 13, 2024
s3tests_boto3/functional/test_s3.py
Outdated
Comment on lines
+13104
to
+13929
| # test streaming uploads with sizes below and above the 8MB multipart threshold | ||
| upload_sizes = [7 * 1024 * 1024, 9 * 1024 * 1024] | ||
|
|
||
| @pytest.mark.checksum | ||
| @pytest.mark.parametrize("size", upload_sizes) | ||
| def test_streaming_upload_checksum_crc32(size): |
Contributor
Author
There was a problem hiding this comment.
the original 7MB size was below the default multipart threshold of 8MB, so wasn't testing multipart uploads. i parameterized these tests for sizes 7MB and 9MB to cover both
8c071c5 to
47f532c
Compare
Contributor
Author
|
these test cases are all passing against aws us-east-1 |
14 tasks
47f532c to
696ba91
Compare
Contributor
Author
|
part of this merged in #564, but the streaming upload tests weren't included |
310a500 to
398efc5
Compare
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Contributor
Author
|
updated to parameterize the checksum algorithm too: |
398efc5 to
c1c5d79
Compare
Contributor
|
in my testing with I guess the earlier version, including awscrt seemed to cause other tests to fail; are you not seeing that? |
Contributor
Author
doh, thanks. i've only tried the checksum tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client.put_object()doesn't seem to support STREAMING payloads, butclient.upload_fileobj()canagainst http endpoint:
against https endpoint: