add test_object_copy_16m to test refcounting of tail objects#473
Merged
alimaredia merged 1 commit intoceph:masterfrom Oct 6, 2022
Merged
add test_object_copy_16m to test refcounting of tail objects#473alimaredia merged 1 commit intoceph:masterfrom
alimaredia merged 1 commit intoceph:masterfrom
Conversation
alimaredia
reviewed
Oct 5, 2022
s3tests_boto3/functional/test_s3.py
Outdated
| key2 = 'obj2' | ||
| client.copy_object(Bucket=bucket_name, Key=key2, CopySource=copy_source) | ||
| response = client.get_object(Bucket=bucket_name, Key=key2) | ||
| eq(response['contentlength'], 16*1024*1024) |
Contributor
There was a problem hiding this comment.
@cbodley contentlength in response should be ContentLength like the above test.
i don't think any of our CopyObj test cases were large enough to have tail objects, so weren't exercising our tail object ref counting strategy Signed-off-by: Casey Bodley <cbodley@redhat.com>
ef1a532 to
defb8eb
Compare
alimaredia
approved these changes
Oct 6, 2022
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i don't think any of our CopyObj test cases were large enough to have tail objects, so weren't exercising our tail object ref ounting strategy