-
Notifications
You must be signed in to change notification settings - Fork 279
rbd: implement rbd_get_data_pool_id
#1164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bcb7ed4 to
3c15386
Compare
|
I was not able to run the tests as this seems to timeout for me, even after attempting to increase the timeout: |
|
CI has already found an error in the code, looks like you forgot to import C in the file. an example: Line 10 in 20995e7
You need the import and a special comment above it to do the C level includes needed, again my link can serve as an example. Process wise you are on track w/ the preview API stuff, thanks! A nitpick about the commit message. Here's how the patch looks in my terminal: I'd request not to include backticks in the subject line as they introduce a 'markdownism' that is not needed in plain text and make typing the subject a little bit harder. Also, ideally there's a blank line between the subject and the next line. Also also, ideally a signed-off-by includes one's real name, some projects enforce it but we generally don't chase after people for it. |
3c15386 to
6d7b6fb
Compare
|
I have addressed your comments @phlogistonjohn, and apologies for the missing imports. |
fcafae1 to
f924e46
Compare
|
I pushed a potential fix yesterday for the failing test. Hopefully that fixes it. |
Add go-ceph binding for rbd_get_data_pool_id which is required to fetch the data pool for erasure coded volumes Signed-off-by: Cameron McDermott <cameron@northflank.com>
f924e46 to
e3f4078
Compare
anoopcs9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks.
Add go-ceph binding for
rbd_get_data_pool_idwhich is required to fetch the data pool for erasure coded volumesChecklist
//go:build ceph_previewmake api-updateto record new APIsNew or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.
The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with
@Mergifyiorebaseto rebase your PR when github indicates that the PR is out of date with the base branch.