cephfs: Use wrappers to handle the ABI changes with chown APIs #1127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82c4157 to
19b39bc
Compare
Collaborator
|
OK, so Go is being pickier than C is in this case? OK seems reasonable. I still think it was a good idea to warn the cephfs team so we don't get disruptive changes in the future. |
Collaborator
Author
Yes. |
19b39bc to
b329416
Compare
Collaborator
Author
|
Something is wrong with GitHub CI. I'll check later. |
Collaborator
Author
|
@Mergifyio rebase |
CephStatx struct returned by mount.Statx() already contains uint32 type converted Uid and Gid data members. Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
Data types for few of the function parameters from chown() family of
APIs recently changed causing cephfs package builds to fail due to
incorrect type cast.
cephfs/file.go:287:99: cannot use _Ctype_int(user) (value of int32 type
_Ctype_int) as _Ctype_uid_t value in variable declaration
cephfs/file.go:287:112: cannot use _Ctype_int(group) (value of int32 type
_Ctype_int) as _Ctype_gid_t value in variable declaration
cephfs/permissions.go:29:67: cannot use _Ctype_int(user) (value of int32 type
_Ctype_int) as _Ctype_uid_t value in variable declaration
cephfs/permissions.go:29:80: cannot use _Ctype_int(group) (value of int32 type
_Ctype_int) as _Ctype_gid_t value in variable declaration
cephfs/permissions.go:38:68: cannot use _Ctype_int(user) (value of int32 type
_Ctype_int) as _Ctype_uid_t value in variable declaration
cephfs/permissions.go:38:81: cannot use _Ctype_int(group) (value of int32 type
_Ctype_int) as _Ctype_gid_t value in variable declaration
Leaning on C's implicit type conversion, introduce wrappers to act as an
intermediary for calling the underlying APIs.
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
✅ Branch has been successfully rebased |
b329416 to
19f29a7
Compare
nixpanic
approved these changes
Jun 6, 2025
Member
nixpanic
left a comment
There was a problem hiding this comment.
I'm a little surprised this doesn't throw a warning, but I like its simplicity. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create backward compatible wrappers to cope with the change in ABI for chown family of APIs counting on the implicit type conversion from C.
fixes #1119