Revert "rgw/admin: Fix version check for return code" #1114
Conversation
|
I'll leave it here until the underlying fixes from ceph gets into tentacle branch. |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
b8a9011 to
3116459
Compare
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
3116459 to
ba3690f
Compare
|
So the regression itself got into the squid branch and thus |
|
@Mergifyio rebase |
This reverts commit 39e5ac0. The regression itself is getting fixed[1] from Ceph side. Therefore the earlier version adjustments won't be required anymore. [1] https://tracker.ceph.com/issues/71159
✅ Branch has been successfully rebased |
ba3690f to
848b0e1
Compare
|
I guess it is more meaningful to see failures on Therefore I suggest to merge the revert and wait for the regression fix to land in corresponding branches ( |
phlogistonjohn
left a comment
There was a problem hiding this comment.
I guess it is more meaningful to see failures on pre-tentacle and pre-squid. At least, for me, the current failures on main and pre-squid are little confusing because one has to digest the underlying version check to make sure that it is the expected failure.
Therefore I suggest to merge the revert and wait for the regression fix to land in corresponding branches (tentacle and squid). Additionally we could file an issue so that we don't forget in future about these failures until necessary fixes are in place.
Fine by me. Approved.
This reverts commit 39e5ac0.
The regression itself is getting fixed from Ceph side. Therefore the earlier version adjustments won't be required anymore.