Skip to content

Conversation

@phlogistonjohn
Copy link
Collaborator

There were two mistakes in the shell that re-installs the ceph-release rpm: (1) the variable was misspelled it should be CEPH_SHA1 not CEPH_SHA and (2) this variable is not set in the environment at all - just the labels. For now, scrape the CEPH_SHA1 value out of the ceph command (which is python, and is fairly easy to scrape). It's a hack on top of a hack but it should get the ci jobs running again.

CI FIX only.

@phlogistonjohn phlogistonjohn added the no-API This PR does not include any changes to the public API of a go-ceph package label Apr 10, 2025
@phlogistonjohn
Copy link
Collaborator Author

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Apr 11, 2025

rebase

✅ Branch has been successfully rebased

@phlogistonjohn phlogistonjohn force-pushed the jjm-more-hacky-ci-workarounds branch from 9335cf1 to e97cc6f Compare April 11, 2025 23:09
@phlogistonjohn phlogistonjohn force-pushed the jjm-more-hacky-ci-workarounds branch from e97cc6f to bdcc89c Compare April 14, 2025 12:09
There were two mistakes in the shell that re-installs the ceph-release
rpm: (1) the variable was misspelled it should be CEPH_SHA1 not
CEPH_SHA and (2) this variable is not set in the environment at all -
just the labels. For now, scrape the CEPH_SHA1 value out of the ceph
command (which is python, and is fairly easy to scrape). It's a hack on
top of a hack but it should get the ci jobs running again.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
@phlogistonjohn phlogistonjohn force-pushed the jjm-more-hacky-ci-workarounds branch from bdcc89c to 96d3825 Compare April 14, 2025 12:09
Copy link
Collaborator

@ansiwen ansiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 629c0fe into ceph:master Apr 14, 2025
15 checks passed
@phlogistonjohn phlogistonjohn deleted the jjm-more-hacky-ci-workarounds branch May 5, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-API This PR does not include any changes to the public API of a go-ceph package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants