rgw/admin: fix op-mask url parameter #1101
Conversation
phlogistonjohn
left a comment
There was a problem hiding this comment.
Could you please expand the commit message to explain how changing the struct tag fixes the issue? Thanks.
|
I Just realized that this PR overlaps with #1054. Were you aware of that? It might have been worthwhile to note that this covers the same topic but also has tests. |
Sorry, I didn't see that PR. |
4c87dbe to
a5ce37b
Compare
Adjusted. |
phlogistonjohn
left a comment
There was a problem hiding this comment.
Looks OK to me. Since rgw is my weak area with regards to go-ceph, I'm asking for a 2nd review on this PR.
anoopcs9
left a comment
There was a problem hiding this comment.
Ah..I see that the CreateUser and ModifyUser API already make use of "op-mask" but the proper url tag was the missing piece.
lgtm, thanks.
|
@Mergifyio rebase |
When creating a user, the RGW expects the op-mask in the URL with a dash instead of an underscore as used for the JSON schema. Signed-off-by: Simon Jürgensmeyer <simon.juergensmeyer@hetzner-cloud.de>
✅ Branch has been successfully rebased |
The op-mask was not correctly transmitted when creating a user.
Checklist
//go:build ceph_previewmake api-updateto record new APIsNew or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.
The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with
@Mergifyiorebaseto rebase your PR when github indicates that the PR is out of date with the base branch.