version bumps - container file and workflow #1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump up the default version of Go used for the go-ceph test images to the latest stable (n+1) version of Go. Note that this doesn't impact the CI as the CI always queries the Go site for the latest version and passes it in. This affected me trying to test things locally. :-) Signed-off-by: John Mulligan <jmulligan@redhat.com>
The container image default ceph version was at v16 (pacific) which is fairly old at this point. This doesn't impact the CI as the ceph version is always passed it, it can be a tad inconvient when running locally to have to remember to pass CEPH_VERSION to the make file every time. Thus, bump up the default ceph version for the image to v19 (squid). Signed-off-by: John Mulligan <jmulligan@redhat.com>
While reviewing the workflow files I noticed that the job matrix was using reef when testing the older and/or unstable Go versions. Since squid has been the stable version of Ceph for some time now I am updating the matrix to test the older and unstable Go versions with squid instead of reef. Signed-off-by: John Mulligan <jmulligan@redhat.com>
ansiwen
approved these changes
Mar 25, 2025
| && true | ||
|
|
||
| ARG GO_VERSION=1.21.8 | ||
| ARG GO_VERSION=1.23.7 |
Collaborator
There was a problem hiding this comment.
maybe we want to force that ARG in the future? Go is moving fast, so we will always be updating this. (We are anyway using the go_version value, right?)
Collaborator
Author
There was a problem hiding this comment.
It's a thought, but I don't like having to do it on the CLI every time. Maybe if the makefile handled it all internally?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump up the default version of the GO version and Ceph version in the container file.
Bump the workflows up to use squid instead of reef when testing alternate Go versions.
Checklist
New or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.
The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with
@Mergifyiorebaseto rebase your PR when github indicates that the PR is out of date with the base branch.