workflows: update actions for new ceph org policy changes #1090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a nice idea but is rubbing up against the new Ceph org policy of only allowing approved actions while I've never had a need/opportunity to use it. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Per the recent ceph org policy to harden the actions pin the actions used in main.yml with the action's sha ids. Signed-off-by: John Mulligan <jmulligan@redhat.com>
In accordance with recent ceph org policy. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Pin official github provided actions and remove the use of a third party action. Replace the 3rd party action with a very hokey manual step. Fixing this for real will involve some future research. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Collaborator
Author
Collaborator
Author
|
Hi @anoopcs9 did you mean to approve? You appear to have only commented and so mergify hasn't taken any action. Thanks :-) |
anoopcs9
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the use of unofficial github actions.
Pin the official github actions with the git sha id.
As per: https://lists.ceph.io/hyperkitty/list/dev@ceph.io/thread/5KWHAST62YAT4P25OO6JYMTRSGSZYPOS/
Checklist
New or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.
The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with
@Mergifyiorebaseto rebase your PR when github indicates that the PR is out of date with the base branch.