rbd: Memory allocation improvements for EncryptionLoad APIs #1078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
For the sake of completeness we add a missing memory allocation for cOpts inside allocateEncryptionOptions() with the following types: - C.rbd_encryption_luks1_format_options_t - C.rbd_encryption_luks2_format_options_t - C.rbd_encryption_luks_format_options_t There is also a re-ordering of statements to make it look more similar to recently added writeEncryptionSpec() for EncryptionLoad2 API. Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
Instead of creating a slice based on a pre-allocated C memory array we could directly go for a slice created via the built-in function make(). Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
b3db13f to
aa1e5f4
Compare
Collaborator
phlogistonjohn
left a comment
There was a problem hiding this comment.
nothing jumps out at me as an issue. Not approving because these come from @ansiwen suggestions and want him to review it.
Collaborator
|
ping @ansiwen |
ansiwen
approved these changes
Feb 19, 2025
Collaborator
ansiwen
left a comment
There was a problem hiding this comment.
Oh, thanks for picking this up! LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See below for the motivation:
Originally posted by @ansiwen in #1061 (comment)
Originally posted by @ansiwen in #1061 (comment)