Skip to content

Conversation

@phlogistonjohn
Copy link
Collaborator

Experimental workaround for ceph ci container build changes.

Depends on #1043

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

New or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.

The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with @Mergifyio rebase to rebase your PR when github indicates that the PR is out of date with the base branch.

@phlogistonjohn phlogistonjohn changed the title [WIP] [ci] workaround recent changes in ceph's CI built container images Dec 12, 2024
@phlogistonjohn
Copy link
Collaborator Author

Anoop's PR #1043 fixes CI failures for the non pre-/main jobs. However, the ci builds are now removing yum repo files and lack CEPH_VERSION environment variable. I'm discussing these with the ceph team members but in the very short term I wanted to see the CI run successfully.

In addition to the continer changes we needed to deal with a recent cephfs fallocate change getting backported (but not released) to various ceph branches. I took the "big hammer" appraoch and just disabled it in more cases than strictly needed.

@phlogistonjohn
Copy link
Collaborator Author

cc @ansiwen for discussion on 2024-12-12.

@dpulls
Copy link

dpulls bot commented Dec 16, 2024

🎉 All dependencies have been resolved !

@mergify
Copy link

mergify bot commented Dec 16, 2024

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

@phlogistonjohn phlogistonjohn marked this pull request as ready for review December 16, 2024 14:04
Recent changes to the ceph ci images are removing the repo files, as
well as some other minor changes. We're working with ceph maintainers
to come up with a clean solution for all, but in the meantime
re-installing the ceph-release rpm recreates the file we need to
continue.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
In pr#1045 we disabled the test for main. It seems that the change
has now been backported to many other branches as the test began
failing on all pre-{quincy,reef,squid} cli jobs too.
Disable the test for pretty much all the active ceph branches.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
Our test code uses CEPH_VERSION but (at least for now) the quay.ceph.io
ci container no longer sets that environment variable.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for fixing the CI.

@anoopcs9 anoopcs9 added no-API This PR does not include any changes to the public API of a go-ceph package extended-review A submitter or reviewer feels the PR needs an extended review period labels Dec 17, 2024
@mergify mergify bot merged commit 394136c into ceph:master Dec 17, 2024
17 checks passed
@anoopcs9
Copy link
Collaborator

Oh..the commit message for 098a730 is bit misleading when it says that pre-{quincy,reef,squid} jobs were failing due to changes backported to those branches. I noticed it after adding the no-API label and a subsequent extended-review label couldn't be added in time to block the merge.

@phlogistonjohn phlogistonjohn deleted the jjm-HAX-anoop-ctr branch December 17, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extended-review A submitter or reviewer feels the PR needs an extended review period no-API This PR does not include any changes to the public API of a go-ceph package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants