Do not use standard names as function arguments #1028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'len' is already a standard library function. revive v1.4.0[1] started looking into function related variables for such standard names as part of redefines-builtin-id rule. Therefore use a different variable name instead of 'len'. [1] https://github.com/mgechev/revive/releases/tag/v1.4.0 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
'len' is already a standard library function. revive v1.4.0[1] started looking into function related variables for such standard names as part of redefines-builtin-id rule. Therefore use a different variable name instead of 'len'. [1] https://github.com/mgechev/revive/releases/tag/v1.4.0 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
nixpanic
approved these changes
Sep 24, 2024
phlogistonjohn
approved these changes
Sep 24, 2024
Collaborator
phlogistonjohn
left a comment
There was a problem hiding this comment.
Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lenis already a standard library function. revive v1.4.0 started looking into function related variables for such standard names as part of redefines-builtin-id rule. Therefore use a different variable name instead oflen.