rbd: add ErrExists as standard error #1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CI jobs fail with something completely unrelated: |
Collaborator
Recently released revive v1.4.0 checks function related variables for |
Collaborator
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
ea56b18 to
9cad79a
Compare
anoopcs9
requested changes
Sep 24, 2024
rbd/errors.go
Outdated
| // Public general error | ||
| const ( | ||
| // ErrExist indicates a non-specific already existing resource. | ||
| ErrExist = rbdError(-C.EXISTS) |
Collaborator
There was a problem hiding this comment.
Suggested change
| ErrExist = rbdError(-C.EXISTS) | |
| ErrExist = rbdError(-C.EEXIST) |
Member
Author
There was a problem hiding this comment.
wow, and I thought I tested this 🤦
9cad79a to
bd9a7fa
Compare
Collaborator
|
@Mergifyio rebase |
Certain operations with RBD can return the C errno EEXIST. Applications using go-ceph benefit from easily detecting this error. Signed-off-by: Niels de Vos <ndevos@ibm.com>
✅ Branch has been successfully rebased |
bd9a7fa to
b6d6c94
Compare
anoopcs9
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain operations with RBD can return the C errno EEXISTS. Applications using go-ceph benefit from easily detecting this error.