Skip to content

Conversation

@pkthapa
Copy link
Contributor

@pkthapa pkthapa commented Sep 5, 2024

A Blackduck scan has reported "Operational Risks as High" for below modules' version.

  • bump github.com/gofrs/uuid from v4.4.0+incompatible to v5.3.0
  • bump golang.org/x/sys from v0.24.0 to v0.25.0
    Signed-off-by: [Pankaj Thapa] pk.thapa66@gmail.com

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

New or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.

The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with @Mergifyio rebase to rebase your PR when github indicates that the PR is out of date with the base branch.

@pkthapa pkthapa force-pushed the usr/pkthapa/bump-uuid-n-go-version branch from 72a7794 to f0dbc4a Compare September 5, 2024 17:52
@phlogistonjohn phlogistonjohn added extended-review A submitter or reviewer feels the PR needs an extended review period no-API This PR does not include any changes to the public API of a go-ceph package labels Sep 6, 2024
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more small request: please add a "Signed off by" line to your commit message. (https://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for)

Thanks!

- bump github.com/gofrs/uuid from v4.4.0+incompatible to v5.3.0
- bump golang.org/x/sys from v0.24.0 to v0.25.0

Signed-off-by: Pankaj Thapa <pk.thapa66@gmail.com>
@pkthapa pkthapa force-pushed the usr/pkthapa/bump-uuid-n-go-version branch from f0dbc4a to eb3c26f Compare September 6, 2024 17:49
@pkthapa
Copy link
Contributor Author

pkthapa commented Sep 6, 2024

One more small request: please add a "Signed off by" line to your commit message. (https://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for)

Thanks!

Done.

Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me. thanks!

@phlogistonjohn
Copy link
Collaborator

@anoopcs9 or @ansiwen I'd like a 2nd set of eyes on this for merge, thanks!

@pkthapa pkthapa requested a review from anoopcs9 September 11, 2024 06:55
@phlogistonjohn phlogistonjohn removed the extended-review A submitter or reviewer feels the PR needs an extended review period label Sep 11, 2024
@mergify mergify bot merged commit d442b12 into ceph:master Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-API This PR does not include any changes to the public API of a go-ceph package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants