Skip to content

Makefile: Use ?= for initial variable definitions(part 2) #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 1 commit into from
Jul 2, 2024
Merged

Makefile: Use ?= for initial variable definitions(part 2) #1004

mergify merged 1 commit into from
Jul 2, 2024

Conversation

@anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented Jul 2, 2024 •
edited
Loading

Iteration #2 of #725.

CEPH_IMG and CEPH_TAG are commonly used to include custom ceph images as base while building go-ceph container images for testing and development purposes.

@anoopcs9 anoopcs9 force-pushed the make-save-custom-vars branch from 4c80d0f to 3d2d03d Compare July 2, 2024 06:25
@anoopcs9 anoopcs9 changed the title Makefile: Do not override custom variables with defaults Makefile: Use ?= for initial variable definitions Jul 2, 2024
@anoopcs9 anoopcs9 force-pushed the make-save-custom-vars branch from 3d2d03d to c4ab29a Compare July 2, 2024 06:47
@anoopcs9 anoopcs9 changed the title Makefile: Use ?= for initial variable definitions Makefile: Use ?= for initial variable definitions(part 2) Jul 2, 2024
@anoopcs9 anoopcs9 force-pushed the make-save-custom-vars branch from c4ab29a to 1d52b55 Compare July 2, 2024 07:07
@phlogistonjohn
Copy link
Collaborator

phlogistonjohn commented Jul 2, 2024

I don't use the environment this heavily for make, but OK.
In the meantime, wrt to the failing nautilus jobs do you prefer to have this PR first with an admin override of the requirements, or wait until we fix/resolve that and then come back to this topic?

@phlogistonjohn phlogistonjohn added the no-API This PR does not include any changes to the public API of a go-ceph package label Jul 2, 2024
@mergify
Copy link

mergify bot commented Jul 2, 2024

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

@anoopcs9 anoopcs9 force-pushed the make-save-custom-vars branch from 1d52b55 to e8d48f6 Compare July 2, 2024 18:03
phlogistonjohn
phlogistonjohn approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anoopcs9
Makefile: Use ?= for initial variable definitions(part 2)
438e213 
:= is not capable of accepting values(for variables) from execution
environment. Therefore replace := with ?= for completeness.

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
@anoopcs9 anoopcs9 force-pushed the make-save-custom-vars branch from e8d48f6 to 438e213 Compare July 2, 2024 18:26
@mergify mergify bot merged commit 83cd6ac into ceph:master Jul 2, 2024
@anoopcs9 anoopcs9 deleted the make-save-custom-vars branch May 9, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

Assignees

No one assigned

Labels

no-API This PR does not include any changes to the public API of a go-ceph package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anoopcs9 @phlogistonjohn