Skip to content

Skip flaky LibRadosIoECPP.CrcZeroWrite test#19

Merged
idryomov merged 1 commit intoceph:mainfrom
petrutlucian94:flaky_test
May 27, 2024
Merged

Skip flaky LibRadosIoECPP.CrcZeroWrite test#19
idryomov merged 1 commit intoceph:mainfrom
petrutlucian94:flaky_test

Conversation

@petrutlucian94
Copy link
Collaborator

@petrutlucian94 petrutlucian94 commented May 26, 2024

One of the recently introduced rados tests is flaky, failing on Linux as well. The "make check" Linux job does not run it, so we're also going to skip it for now.

This was referenced May 26, 2024
Merged
Merged
tchaikov
tchaikov approved these changes May 26, 2024
View reviewed changes
Copy link

@tchaikov tchaikov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! lgtm. would be better to track the flaky test with an issue on tracker.

@petrutlucian94
Copy link
Collaborator Author

petrutlucian94 commented May 26, 2024

thanks! lgtm. would be better to track the flaky test with an issue on tracker.

Good point, I've opened an issue: https://tracker.ceph.com/issues/66226

@idryomov idryomov changed the title Skip flaky test Skip flaky LibRadosIoECPP.CrcZeroWrite test May 27, 2024
@idryomov
Copy link
Contributor

idryomov commented May 27, 2024

Every time I saw LibRadosIoECPP.CrcZeroWrite fail, LibRadosIoECPP.CmpExtPP, LibRadosIoECPP.CmpExtDNEPP and LibRadosIoECPP.CmpExtMismatchPP failed as well. I'm assuming it's because they operate on an object with the same name in a pool with the same name and recreate_pool() is not called when LibRadosIoECPP.CrcZeroWrite fails?

Just want to confirm that only a single test needs to be skipped.

idryomov
idryomov reviewed May 27, 2024
View reviewed changes
Copy link
Contributor

@idryomov idryomov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the commit title to match the title of the PR and link the tracker from the commit message:

[...]
we're also going to skip it for now.

This is tracked in https://tracker.ceph.com/issues/66226.

@petrutlucian94
Copy link
Collaborator Author

petrutlucian94 commented May 27, 2024

Every time I saw LibRadosIoECPP.CrcZeroWrite fail, LibRadosIoECPP.CmpExtPP, LibRadosIoECPP.CmpExtDNEPP and LibRadosIoECPP.CmpExtMismatchPP failed as well. I'm assuming it's because they operate on an object with the same name in a pool with the same name and recreate_pool() is not called when LibRadosIoECPP.CrcZeroWrite fails?

Exactly, we only need to skip LibRadosIoECPP.CrcZeroWrite.

@petrutlucian94
Skip flaky LibRadosIoECPP.CrcZeroWrite test
be33cbc 
One of the recently introduced rados tests is flaky, failing on
Linux as well. The "make check" Linux job does not run it, so
we're also going to skip it for now.

This is tracked in https://tracker.ceph.com/issues/66226.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
@idryomov idryomov merged commit e668dd3 into ceph:main May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaikov tchaikov tchaikov approved these changes

@idryomov idryomov idryomov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@petrutlucian94 @idryomov @tchaikov