Check 'ceph orch status' output#283
Merged
ricardoasmarques merged 1 commit intoceph:masterfrom Jul 16, 2020
Merged
Conversation
ceph orch status outputceph orch status output
89985bd to
41d7a0d
Compare
smithfarm
reviewed
Jul 15, 2020
| if status_ret['retcode'] != 0: | ||
| return False | ||
| status = json.loads(status_ret['stdout']) | ||
| if not status.get('available'): |
Contributor
There was a problem hiding this comment.
status.get('available', False) ?
smithfarm
approved these changes
Jul 15, 2020
Instead of simply rely on return code, we need to check if "available: true" is returned. Signed-off-by: Ricardo Marques <rimarques@suse.com>
41d7a0d to
b360d74
Compare
ceph orch status output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After ceph/ceph#35805 is backported (ceph/ceph#35898)Instead of simply rely on return code, we need to check if "available: true" is returned, because:
Signed-off-by: Ricardo Marques rimarques@suse.com