cls/rbd: mark cls_rbd_snap as forward incompatible since nautilus#24
Merged
idryomov merged 1 commit intoceph:masterfrom Jun 18, 2025
Merged
Conversation
Contributor
Author
|
@idryomov hi Ilya, could you please help review this change? |
This was referenced Jun 15, 2025
Contributor
|
nit: pr and commit title say "cls/rgw" not rbd |
b5ba3e5 to
6689a47
Compare
Contributor
Author
indeed. corrected. |
idryomov
reviewed
Jun 17, 2025
ceph/ceph@32b14ed1 broke backward compatibility of cls_rbd_snap's on-disk format by removing decoding of the "parent" field. When re-encoding instances, this field is now lost even if originally non-empty. This breaking change should have been caught by readable.sh tests, but the tests passed because they reused the same instance for re-encoding, preserving undecoded fields by only overwriting decoded ones. An upcoming change in ceph/ceph will allocate fresh instances for each decode operation instead of reusing existing ones. This will expose the compatibility break and cause test failures. Mark cls_rbd_snap as forward incompatible starting from v15 (earliest version with archived corpus) to properly handle this breaking change and prepare for the improved testing approach. Signed-off-by: Kefu Chai <tchaikov@gmail.com>
6689a47 to
57b7487
Compare
Contributor
Author
|
changelog
|
Contributor
Author
|
@idryomov hi Ilya, thanks for your review! could you take another look? |
idryomov
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ceph/ceph@32b14ed1 broke backward compatibility of cls_rbd_snap's on-disk format by removing decoding of the "parent" field. When re-encoding instances, this field is now lost even if originally non-empty.
This breaking change should have been caught by readable.sh tests, but the tests passed because they reused the same instance for re-encoding, preserving undecoded fields by only overwriting decoded ones.
An upcoming change in ceph/ceph will allocate fresh instances for each decode operation instead of reusing existing ones. This will expose the compatibility break and cause test failures.
Mark cls_rbd_snap as forward incompatible starting from v15 (earliest version with archived corpus) to properly handle this breaking change and prepare for the improved testing approach.