Merged
Conversation
Need to adjust all the new types forward_incompat folders Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
bead101 to
c9c8ffe
Compare
This was referenced Aug 9, 2023
Contributor
|
The starter's doc: https://docs.ceph.com/en/main/dev/corpus/. The clue of this change is to ignore forward-incompatibility (starting at particular version) of some types that we were missing in The structure of the list comes from test_object() {
# ...
if $CEPH_DENCODER type $type 2>/dev/null; then
#echo "type $type";
echo " $vdir/objects/$type"
# is there a fwd incompat change between $arversion and $version?
incompat=""
incompat_paths=""
sawarversion=0
for iv in `ls $dir/archive | sort -n`; do
if [ "$iv" = "$arversion" ]; then
sawarversion=1
fi
if [ $sawarversion -eq 1 ] && [ -e "$dir/archive/$iv/forward_incompat/$type" ]; then
incompat="$iv"
# Check if we'll be ignoring only specified objects, not whole type. If so, remember
# all paths for this type into variable. Assuming that this path won't contain any
# whitechars (implication of above for loop).
if [ -d "$dir/archive/$iv/forward_incompat/$type" ]; then
if [ -n "`ls $dir/archive/$iv/forward_incompat/$type/ | sort -n`" ]; then
incompat_paths="$incompat_paths $dir/archive/$iv/forward_incompat/$type"
else
echo "type $type directory empty, ignoring whole type instead of single objects"
fi;
fi
fi
if [ "$iv" = "$version" ]; then
rm -rf $tmp1 $tmp2
break
fi
done
if [ -n "$incompat" ]; then
if [ -z "$incompat_paths" ]; then
echo "skipping incompat $type version $arversion, changed at $incompat < code $myversion"
rm -rf $tmp1 $tmp2
return
else
# If we are ignoring not whole type, but objects that are in $incompat_path,
# we don't skip here, just give info.
echo "postponed skip one of incompact $type version $arversion, changed at $incompat < code $myversion"
fi;
fi |
rzarzynski
approved these changes
Aug 23, 2023
Contributor
rzarzynski
left a comment
There was a problem hiding this comment.
LGTM with one minor thing: the commit title. Before merging it would be rework to reflect we're ignoring forward incompatibility of some old types we're registering now to ceph-dencoder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to adjust all the new types forward_incompat folders