merge queue: embarking devel (0a2e71a) and #6084 together#6090
Closed
mergify[bot] wants to merge 2 commits into
Closed
merge queue: embarking devel (0a2e71a) and #6084 together#6090mergify[bot] wants to merge 2 commits into
mergify[bot] wants to merge 2 commits into
Conversation
it was searching in host list. but host list in Namespace is not belong to hostNqn we use. this host list is for Namespace Masking feature. (out of scope here). I catched it, when I created 2 PVCs + 2 pods then I remove 1 pod and I saw it deleted the host even though there is still 1 live pod. so in our case, we just need to check the len of the ns list (for specific subsystemNqn) if left more than 1, dont remove the host! Signed-off-by: gadi-didi <gadi.didi@ibm.com>
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.33 |
Collaborator
|
/test ci/centos/upgrade-tests-cephfs |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.34 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.33 |
Collaborator
|
/test ci/centos/upgrade-tests-rbd |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.34 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.33 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.34 |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.35 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.35 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.35 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch devel (0a2e71a) and #6084 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #6084.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:#approved-reviews-by >= 2[🛡 GitHub branch protection]#changes-requested-reviews-by = 0[🛡 GitHub branch protection]base=develstatus-success=codespellstatus-success=go-teststatus-success=golangci-lintstatus-success=lint-extrasstatus-success=mod-checkstatus-success=multi-arch-buildstatus-success=uncommitted-code-checklabel=ci/skip/e2estatus-success=ci/centos/k8s-e2e-external-storage/1.33status-success=ci/centos/k8s-e2e-external-storage/1.34status-success=ci/centos/k8s-e2e-external-storage/1.35status-success=ci/centos/mini-e2e-helm/k8s-1.33status-success=ci/centos/mini-e2e-helm/k8s-1.34status-success=ci/centos/mini-e2e-helm/k8s-1.35status-success=ci/centos/mini-e2e/k8s-1.33status-success=ci/centos/mini-e2e/k8s-1.34status-success=ci/centos/mini-e2e/k8s-1.35status-success=ci/centos/upgrade-tests-cephfsstatus-success=ci/centos/upgrade-tests-rbdbase~=^(release-.+)$status-success=codespellstatus-success=go-teststatus-success=golangci-lintstatus-success=lint-extrasstatus-success=mod-checkstatus-success=multi-arch-buildstatus-success=uncommitted-code-checklabel=ci/skip/e2estatus-success=ci/centos/k8s-e2e-external-storage/1.32status-success=ci/centos/mini-e2e-helm/k8s-1.32status-success=ci/centos/mini-e2e/k8s-1.32status-success=ci/centos/k8s-e2e-external-storage/1.33status-success=ci/centos/k8s-e2e-external-storage/1.34status-success=ci/centos/mini-e2e-helm/k8s-1.33status-success=ci/centos/mini-e2e-helm/k8s-1.34status-success=ci/centos/mini-e2e/k8s-1.33status-success=ci/centos/mini-e2e/k8s-1.34status-success=ci/centos/upgrade-tests-cephfsstatus-success=ci/centos/upgrade-tests-rbdbase=release-v3.15status-success=codespellstatus-success=go-teststatus-success=golangci-lintstatus-success=lint-extrasstatus-success=mod-checkstatus-success=multi-arch-buildstatus-success=uncommitted-code-checklabel=ci/skip/e2estatus-success=ci/centos/k8s-e2e-external-storage/1.31status-success=ci/centos/k8s-e2e-external-storage/1.32status-success=ci/centos/mini-e2e-helm/k8s-1.31status-success=ci/centos/mini-e2e-helm/k8s-1.32status-success=ci/centos/mini-e2e/k8s-1.31status-success=ci/centos/mini-e2e/k8s-1.32status-success=ci/centos/k8s-e2e-external-storage/1.33status-success=ci/centos/mini-e2e-helm/k8s-1.33status-success=ci/centos/mini-e2e/k8s-1.33status-success=ci/centos/upgrade-tests-cephfsstatus-success=ci/centos/upgrade-tests-rbdbase=ci/centosstatus-success=ci/centos/jjb-validatestatus-success=ci/centos/job-validationRequired conditions to stay in the queue:
#approved-reviews-by >= 2[🛡 GitHub branch protection]#changes-requested-reviews-by = 0[🛡 GitHub branch protection]