Skip to content

merge queue: embarking devel (824eb99) and #5641 together#6051

Closed
mergify[bot] wants to merge 13 commits into
develfrom
mergify/merge-queue/328bd23875
Closed

merge queue: embarking devel (824eb99) and #5641 together#6051
mergify[bot] wants to merge 13 commits into
develfrom
mergify/merge-queue/328bd23875

Conversation

@mergify

@mergify mergify Bot commented Feb 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🎉 This pull request has been checked successfully and will be merged soon. 🎉

Branch devel (824eb99) and #5641 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #5641.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue default for merge:

  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • any of:
    • all of:
      • base=devel
      • status-success=codespell
      • status-success=go-test
      • status-success=golangci-lint
      • status-success=lint-extras
      • status-success=mod-check
      • status-success=multi-arch-build
      • status-success=uncommitted-code-check
      • any of:
        • all of:
          • status-success=ci/centos/k8s-e2e-external-storage/1.33
          • status-success=ci/centos/k8s-e2e-external-storage/1.34
          • status-success=ci/centos/k8s-e2e-external-storage/1.35
          • status-success=ci/centos/mini-e2e-helm/k8s-1.33
          • status-success=ci/centos/mini-e2e-helm/k8s-1.34
          • status-success=ci/centos/mini-e2e-helm/k8s-1.35
          • status-success=ci/centos/mini-e2e/k8s-1.33
          • status-success=ci/centos/mini-e2e/k8s-1.34
          • status-success=ci/centos/mini-e2e/k8s-1.35
          • status-success=ci/centos/upgrade-tests-cephfs
          • status-success=ci/centos/upgrade-tests-rbd
        • label=ci/skip/e2e
    • all of:
      • base~=^(release-.+)$
      • any of:
        • label=ci/skip/e2e
        • all of:
          • status-success=ci/centos/k8s-e2e-external-storage/1.32
          • status-success=ci/centos/mini-e2e-helm/k8s-1.32
          • status-success=ci/centos/mini-e2e/k8s-1.32
          • status-success=ci/centos/k8s-e2e-external-storage/1.33
          • status-success=ci/centos/k8s-e2e-external-storage/1.34
          • status-success=ci/centos/mini-e2e-helm/k8s-1.33
          • status-success=ci/centos/mini-e2e-helm/k8s-1.34
          • status-success=ci/centos/mini-e2e/k8s-1.33
          • status-success=ci/centos/mini-e2e/k8s-1.34
          • status-success=ci/centos/upgrade-tests-cephfs
          • status-success=ci/centos/upgrade-tests-rbd
      • status-success=codespell
      • status-success=go-test
      • status-success=golangci-lint
      • status-success=lint-extras
      • status-success=mod-check
      • status-success=multi-arch-build
      • status-success=uncommitted-code-check
    • all of:
      • base=release-v3.15
      • any of:
        • label=ci/skip/e2e
        • all of:
          • status-success=ci/centos/k8s-e2e-external-storage/1.31
          • status-success=ci/centos/k8s-e2e-external-storage/1.32
          • status-success=ci/centos/mini-e2e-helm/k8s-1.31
          • status-success=ci/centos/mini-e2e-helm/k8s-1.32
          • status-success=ci/centos/mini-e2e/k8s-1.31
          • status-success=ci/centos/mini-e2e/k8s-1.32
          • status-success=ci/centos/k8s-e2e-external-storage/1.33
          • status-success=ci/centos/mini-e2e-helm/k8s-1.33
          • status-success=ci/centos/mini-e2e/k8s-1.33
          • status-success=ci/centos/upgrade-tests-cephfs
          • status-success=ci/centos/upgrade-tests-rbd
      • status-success=codespell
      • status-success=go-test
      • status-success=golangci-lint
      • status-success=lint-extras
      • status-success=mod-check
      • status-success=multi-arch-build
      • status-success=uncommitted-code-check
    • all of:
      • base=ci/centos
      • status-success=ci/centos/jjb-validate
      • status-success=ci/centos/job-validation

Required conditions to stay in the queue:

---
checking_base_sha: 824eb992ea49de5873f1e6bce122bc97f1d7aa0e
previous_failed_batches: []
pull_requests:
  - number: 5641
...

gadididi and others added 13 commits February 10, 2026 11:22
@gadididi @nixpanic
doc: add examples for NVMe-oF
6d85503 
Add example of storage class and pvc, need to modify storage class
before use!

Signed-off-by: Niels de Vos <ndevos@ibm.com>
Signed-off-by: gadi-didi <gadi.didi@ibm.com>
@nixpanic @gadididi
deploy: add deployment files for NVMe-oF
7441e91 
The deployment files make it possible to start the NVMe-oF controller
and nodeplugin by the e2e suite.

Co-authored-by: gadi-didi <gadi.didi@ibm.com>
Signed-off-by: Niels de Vos <ndevos@ibm.com>
@nixpanic
e2e: deploy NVMe-oF provisioner and nodeplugin
73aea58 
Signed-off-by: Niels de Vos <ndevos@ibm.com>
@nixpanic
e2e: create NVMe-oF StorageClass
671becc 
Signed-off-by: Niels de Vos <ndevos@ibm.com>
@nixpanic
e2e: add NVMe-oF volume creation test
db292a0 
Create a PVC and wait for it to get Bound. This does not exersice the
node-plugin yet, only the controller/provisioner.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
@nixpanic
e2e: enable nvmeof testing by default
ecfd07f 
Signed-off-by: Niels de Vos <ndevos@ibm.com>
@nixpanic
e2e: record the logs from the gateway Pod in case it fails to start
cebf17f 
Signed-off-by: Niels de Vos <ndevos@ibm.com>
@nixpanic
ci: use Rook 1.18.4
243a596 
Recent versions of Rook use Ceph-CSI Operator by default. There is no
need to have Ceph-CSI deployed by Rook, as our CI deploys it from the PR
that is being tested.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
@nixpanic
ci: always add /run/udev/data into containers started by minikube
5c25716 
ceph-volume in Tentacle (v20) uses udev data to detect some properties
of the potential OSDs. Inside the minikube cluster (running with
Podman), there is no udev. Mounting the host udev runtime data into the
containers makes ceph-volume happy.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
@nixpanic
e2e: log details of the NVMe-oF deployment on failure
3d1a0fb 
Signed-off-by: Niels de Vos <ndevos@ibm.com>
@gadididi @nixpanic
doc: add examples for VAC NVMe-oF
5b5278d 
Add example of volumeAttributesClass yaml files.
it is possible to use in with PVC, by using the field volumeAttributesClassName.

Co-authored-by: Niels de Vos <ndevos@ibm.com>
Signed-off-by: gadi-didi <gadi.didi@ibm.com>
@nixpanic
e2e: skip NVMe-oF testing on Ceph clusters < 20.0
17d5ccc 
Ceph Tentacle is required for deploying the NVMe-oF gateway. Earlier
versions do not support the gateway.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
@mergify
Merge of #5641
a689d1c
@ceph-csi-bot ceph-csi-bot added component/testing Additional test cases or CI work keepalive This label can be used to disable stale bot activiity in the repo ci/skip/multi-arch-build skip building on multiple architectures component/nvme-of Issues and PRs related to NVMe-oF. queued ok-to-test Label to trigger E2E tests labels Feb 11, 2026
@ceph-csi-bot

ceph-csi-bot commented Feb 11, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.35

@ceph-csi-bot

ceph-csi-bot commented Feb 11, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.34

@ceph-csi-bot

ceph-csi-bot commented Feb 11, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.35

@ceph-csi-bot

ceph-csi-bot commented Feb 11, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.34

@ceph-csi-bot

ceph-csi-bot commented Feb 11, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot

ceph-csi-bot commented Feb 11, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.33

@ceph-csi-bot

ceph-csi-bot commented Feb 11, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e/k8s-1.35

@ceph-csi-bot

ceph-csi-bot commented Feb 11, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e/k8s-1.34

@ceph-csi-bot

ceph-csi-bot commented Feb 11, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot

ceph-csi-bot commented Feb 11, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.33

@ceph-csi-bot

ceph-csi-bot commented Feb 11, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e/k8s-1.33

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Feb 11, 2026
@mergify mergify Bot mentioned this pull request Feb 11, 2026
Merged
@mergify mergify Bot closed this Feb 11, 2026
@mergify mergify Bot deleted the mergify/merge-queue/328bd23875 branch February 11, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ci/skip/multi-arch-build skip building on multiple architectures component/nvme-of Issues and PRs related to NVMe-oF. component/testing Additional test cases or CI work keepalive This label can be used to disable stale bot activiity in the repo queued

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ceph-csi-bot @gadididi @nixpanic